Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #2685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #2685

wants to merge 1 commit into from

Conversation

AndreaTkachuk
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code is well-structured and meets all the core requirements. Just a small note: make sure the imdbId is assigned correctly from the input value instead of using count.toString(). Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

description: description || '',
imgUrl,
imdbUrl,
imdbId: count.toString(),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The imdbId is being set to count.toString(), which might not be the intended behavior. Ensure that imdbId is correctly assigned from the input value rather than the count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants