Develop #1154
Open
Develop #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StasSokolov1
suggested changes
Dec 18, 2024
src/Root.tsx
Outdated
| <Route path=":slug" element={<PeoplePage />} /> | ||
| </Route> | ||
| <Route path="*" element={<h1 className="title">Page not found</h1>} /> | ||
| <Route path="home" element={<Navigate to="/" replace={true} />} /> |
There was a problem hiding this comment.
Suggested change
| <Route path="home" element={<Navigate to="/" replace={true} />} /> | |
| <Route path="home" element={<Navigate to="/" replace />} /> |
just one small update
src/components/PeopleFilters.tsx
Outdated
Comment on lines
12
to
16
| const sexValues = { | ||
| all: 'All', | ||
| m: 'Male', | ||
| f: 'Female', | ||
| }; |
src/components/PersonRow.tsx
Outdated
| search: searchParams.toString(), | ||
| }} | ||
| className={classNames({ | ||
| 'has-text-danger': person.sex === 'f', |
There was a problem hiding this comment.
what is f? let's create enum with these values f, m
src/components/PersonRow.tsx
Outdated
| <td>{person.born}</td> | ||
| <td>{person.died}</td> | ||
| <td> | ||
| <ParentLink person={person} parent={'mother'} /> |
There was a problem hiding this comment.
for mother and father we can also create enum
src/hooks/usePeople.ts
Outdated
| const [isPeopleError, setIsPeopleError] = useState(false); | ||
|
|
||
| const loadPeople = useCallback(async () => { | ||
| setIsPeopleLoading(true); |
There was a problem hiding this comment.
let's set initial value for isPeopleLoading true so we can remove this line
src/pages/PeoplePage.tsx
Outdated
| let status = 'loading'; | ||
|
|
||
| if (isPeopleError) { | ||
| status = 'error'; |
src/utils/sortHelper.ts
Outdated
Comment on lines
11
to
16
| .filter(person => person.name.toLowerCase().includes(query.toLowerCase())) | ||
| .filter(person => !sex || person.sex === sex) | ||
| .filter( | ||
| person => | ||
| !centuries.length || centuries.includes(getPersonCentury(person)), | ||
| ) |
There was a problem hiding this comment.
do we really need three filters? let's combine all these rules into one
StasSokolov1
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK