add task solution #487
Closed
add task solution #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-mirzoian
suggested changes
Oct 3, 2023
src/components/PersonLink.tsx
Outdated
| > | ||
| {motherName} | ||
| </Link> | ||
| ) : (motherName || '-')} |
There was a problem hiding this comment.
const NOT_SET_VALUE = '-';
...
) : (motherName || NOT_SET_VALUE)}
src/pages/PeoplePage.tsx
Outdated
Comment on lines
44
to
47
| father: peopleFormServer | ||
| .find(father => father.name === person.fatherName), | ||
| mother: peopleFormServer | ||
| .find(mother => mother.name === person.motherName), |
There was a problem hiding this comment.
Suggested change
| father: peopleFormServer | |
| .find(father => father.name === person.fatherName), | |
| mother: peopleFormServer | |
| .find(mother => mother.name === person.motherName), | |
| father: peopleFormServer | |
| .find(({ name })=> name === person.fatherName), | |
| mother: peopleFormServer | |
| .find(({ name }) => name === person.motherName), |
src/utils/getFilteredPeople.tsx
Outdated
Comment on lines
19
to
21
| person => person.name.toLowerCase().includes(normalizedQuery) | ||
| || person.fatherName?.toLowerCase().includes(normalizedQuery) | ||
| || person.motherName?.toLowerCase().includes(normalizedQuery), |
There was a problem hiding this comment.
You use a similar action three times - this can be taken as a helper function
src/utils/getFilteredPeople.tsx
Outdated
| }: FilterParams): Person[] => { | ||
| let filteredPeople = [...people]; | ||
|
|
||
| if (query.trim() !== '') { |
There was a problem hiding this comment.
Suggested change
| if (query.trim() !== '') { | |
| if (!!query.trim()) { |
src/utils/getFilteredPeople.tsx
Outdated
| ); | ||
| } | ||
|
|
||
| if (centuries.length > 0) { |
There was a problem hiding this comment.
Suggested change
| if (centuries.length > 0) { | |
| if (!!centuries.length) { |
src/utils/getFilteredPeople.tsx
Outdated
|
|
||
| if (centuries.length > 0) { | ||
| filteredPeople = filteredPeople.filter((person) => { | ||
| return centuries.includes(Math.ceil(person.born / 100).toString()); |
There was a problem hiding this comment.
Avoid using "magiv values" (100 is magic value)
src/utils/getFilteredPeople.tsx
Outdated
| sort, | ||
| order, | ||
| }: FilterParams): Person[] => { | ||
| let filteredPeople = [...people]; |
There was a problem hiding this comment.
The filter array method returns a copy of the array, so you don't need to do it manually
roman-mirzoian
suggested changes
Oct 5, 2023
src/components/PersonLink.tsx
Outdated
| > | ||
| {motherName} | ||
| </Link> | ||
| ) : (motherName || '-')} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK