Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial solution #493

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

desevoker
Copy link

Copy link

@serkrops serkrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks very good!

Copy link

@Moroz-Dmytro Moroz-Dmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@desevoker desevoker requested a review from Moroz-Dmytro October 6, 2023 10:26
Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 🔥

src/api.ts Show resolved Hide resolved
src/components/PeopleFilters.tsx Outdated Show resolved Hide resolved
Comment on lines +22 to +33
let iconClass = 'fa-sort-down';

if (sort !== field) {
params.sort = field;

iconClass = 'fa-sort';
} else if (sort === field && !order) {
params.sort = field;
params.order = SortOrder.Desc;

iconClass = 'fa-sort-up';
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create a function that returns iconClass and move it outside the component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants