Develop #511
Open
Develop #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-mirzoian
suggested changes
Oct 5, 2023
There was a problem hiding this comment.
Good job, but there is quite a bit of work to be done.
There are also currently several problems with the application itself:
- When switching to the
People page, both the loader and the people data will be renedred at the same time:
https://gyazo.com/d715d2c8a2717835cc280ab49675c0e9 - Sorting does not work:
https://gyazo.com/a87eb63dfd784c296bee21703737795c
BudnikOleksii
suggested changes
Oct 9, 2023
BudnikOleksii
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
You still have the same page in the components folder, don't forget to get rid of it:
Comment on lines
+36
to
+46
| setTimeout(async () => { | ||
| try { | ||
| const peopleFromServer = await getPeople(); | ||
|
|
||
| setPeople(getPreparedPeople(peopleFromServer)); | ||
| } catch (error) { | ||
| setIsError(true); | ||
| } finally { | ||
| setIsLoading(false); | ||
| } | ||
| }, 1000); |
There was a problem hiding this comment.
Why do you fetch in the setTimeout callback?
It doesn't make any sense. Get rid of a timeout
roman-mirzoian
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK