Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit solution #517

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

commit solution #517

wants to merge 3 commits into from

Conversation

domalewski
Copy link

export const PeoplePage = () => {
const [people, setPeople] = useState<Person[]>([]);
const [error, setError] = useState(false);
const [loading, setLoading] = useState<boolean>(false);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could initially set loading to true, and when you're done fetching your data - set it to false

const [loading, setLoading] = useState<boolean>(false);

useEffect(() => {
setLoading(true);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take a look at comment above ⬆️

centuries,
sort,
order,
}: Params):Person[] => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier?

@domalewski domalewski requested a review from choeqq October 6, 2023 07:19
Copy link

@choeqq choeqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants