working versiun #530
Open
working versiun #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choeqq
suggested changes
Oct 9, 2023
choeqq
approved these changes
Oct 10, 2023
| getPeople() | ||
| .then((data) => { | ||
| setPeople(data); | ||
| setIsLoading(false); |
There was a problem hiding this comment.
typically we want to stop setIsLoading(false) on .finally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
Known issues:
1. nested ternary in PeopleTable (todo)3. have to add "There are no people matching the current search criteria" message (todo)4. missed the male/female filter, need to apply that (todo)