solution #563

tndeineka · 2023-10-29T11:14:31Z

OleziO · 2023-10-29T11:45:05Z

src/utils/filteredPeople.tsx

+    });
+  }
+
+  if (order === 'desc') {


Move order names to the enum

etojeDenys

looks good

etojeDenys · 2023-10-30T07:53:58Z

src/components/PeopleFilters.tsx

+  const query = searchParams.get('query') || '';
+  const sex = searchParams.get('sex') || null;
+  const centuries = searchParams.getAll('centuries') || [];
+  const allCenturies = ['16', '17', '18', '19', '20'];


we can move this var out of the component as a constant

solution

5094c9d

OleziO suggested changes Oct 29, 2023

View reviewed changes

src/utils/filteredPeople.tsx Outdated

});

}

if (order === 'desc') {

Copy link

OleziO Oct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move order names to the enum

add enum

75dcf9e

tndeineka requested a review from OleziO October 30, 2023 07:09

etojeDenys approved these changes Oct 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

solution #563

solution #563

tndeineka commented Oct 29, 2023

OleziO Oct 29, 2023

etojeDenys left a comment

etojeDenys Oct 30, 2023

solution #563

Are you sure you want to change the base?

solution #563

Conversation

tndeineka commented Oct 29, 2023

OleziO Oct 29, 2023

Choose a reason for hiding this comment

etojeDenys left a comment

Choose a reason for hiding this comment

etojeDenys Oct 30, 2023

Choose a reason for hiding this comment