made people-table-advanced #597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlhaKoziuk
reviewed
Nov 20, 2023
src/components/PeopleFilters.tsx
Outdated
| if (!century) { | ||
| return getSearchWith(searchParams, { | ||
| centuries: [], | ||
| }); |
There was a problem hiding this comment.
as I understand if we want to remove params, we should pass value = null
OlhaKoziuk
reviewed
Nov 20, 2023
src/components/PeopleFilters.tsx
Outdated
| const toggleAllReset = () => { | ||
| return getSearchWith( | ||
| searchParams, { query: null, centuries: [], sex: null }, | ||
| ); |
OlhaKoziuk
reviewed
Nov 20, 2023
src/components/PeopleFilters.tsx
Outdated
| All | ||
| </Link> | ||
| <Link | ||
| className={cn({ 'is-active': sex === 'm' })} |
There was a problem hiding this comment.
For sure. Also render as a list (using map). Fix everywhere
OlhaKoziuk
reviewed
Nov 20, 2023
src/components/PeoplePage.tsx
Outdated
| case 'sex': | ||
| filteredPeople = filteredPeople.sort((person1, person2) => { | ||
| return (order === 'desc') | ||
| ? person2[sort].localeCompare(person1[sort]) |
superpooperxxx
suggested changes
Nov 22, 2023
src/components/PeoplePage.tsx
Outdated
| setIsLoading(true); | ||
|
|
||
| getPeople() | ||
| .then((peopleFromServer) => setPeople(peopleFromServer)) |
src/components/PeoplePage.tsx
Outdated
| .finally(() => setIsLoading(false)); | ||
| }, []); | ||
|
|
||
| const getFilteredPeople = () => { |
There was a problem hiding this comment.
Let's move this function to separate file and receive people and filters as a parameters
src/components/PeoplePage.tsx
Outdated
Comment on lines
14
to
19
| const [searchParams] = useSearchParams(); | ||
| const centuries = searchParams.getAll('centuries') || []; | ||
| const sex = searchParams.get('sex') || 'All'; | ||
| const query = searchParams.get('query') || ''; | ||
| const sort = searchParams.get('sort') || ''; | ||
| const order = searchParams.get('order') || ''; |
src/components/PeopleFilters.tsx
Outdated
| All | ||
| </Link> | ||
| <Link | ||
| className={cn({ 'is-active': sex === 'm' })} |
There was a problem hiding this comment.
For sure. Also render as a list (using map). Fix everywhere
StasSokolov
approved these changes
Nov 23, 2023
| ); | ||
| } | ||
|
|
||
| if (sex !== 'All') { |
There was a problem hiding this comment.
not critical but All is used in many places your code, will be better create enum for sort fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK