first try #605
Open
first try #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilugdmytro
approved these changes
Nov 21, 2023
vmiskiv
suggested changes
Nov 22, 2023
src/components/PeopleFilters.tsx
Outdated
| <a className="is-active" href="#/people">All</a> | ||
| <a className="" href="#/people?sex=m">Male</a> | ||
| <a className="" href="#/people?sex=f">Female</a> | ||
| <SearchLink |
src/components/PeopleFilters.tsx
Outdated
Comment on lines
63
to
68
| setSearchParams( | ||
| getSearchWith( | ||
| searchParams, | ||
| (event.target.value.trim()) | ||
| ? { query: event.target.value.trim().toLocaleLowerCase() } | ||
| : { query: null }, |
There was a problem hiding this comment.
Would be better to move the logic separately in a handle function
src/components/PeoplePage.tsx
Outdated
| const [error, setError] = useState(false); | ||
| const [isLoading, setIsLoading] = useState(false); | ||
|
|
||
| // const [people, setPeople] = useState(peopleFromServer); |
There was a problem hiding this comment.
Don't forget to remove commented out lines
src/components/PeoplePage.tsx
Outdated
|
|
||
| // #region getVisiblePeople | ||
|
|
||
| let visiblePeople = [...peopleFromServer]; |
There was a problem hiding this comment.
Should be used a separate function to filter and sort from line 45 to line 89 which will return a filtered array
src/components/PeoplePage.tsx
Outdated
| <p>There are no people matching the current search criteria</p> | ||
|
|
||
| <PeopleTable /> | ||
| {(() => { |
There was a problem hiding this comment.
Immediately invoked function with switch case using directly in JSX decrease readability. It would be better to use conditional rendering here. It is much more simplify and readable
StasSokolov
approved these changes
Nov 29, 2023
| if (sort) { | ||
| result.sort((a, b) => { | ||
| switch (sort) { | ||
| case 'name': |
There was a problem hiding this comment.
will be better create enum for types and reuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK