add task solution #619
Open
add task solution #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superpooperxxx
suggested changes
Nov 24, 2023
src/pages/PeoplePage.tsx
Outdated
|
|
||
| export const PeoplePage: React.FC = () => { | ||
| const [people, setPeople] = useState<Person[]>([]); | ||
| const [visiblePeople, setVisiblePeople] = useState<Person[]>([]); |
There was a problem hiding this comment.
Storing visiblePeople in a state will cause extra re-renders. Make it a variable
src/pages/PeoplePage.tsx
Outdated
| } | ||
|
|
||
| setVisiblePeople(preparedPeopleList); | ||
| }, [sex, query, centuries, sort, order]); |
There was a problem hiding this comment.
This useEffect is triggered almost always. What I suggest:
- Take filtering logic to separate function in separate file
- Accept there a
searchParamsas a param - Call this function on each render and storing the result in
visiblePeople
| <th key={key}> | ||
| <span className="is-flex is-flex-wrap-nowrap"> | ||
| {key} | ||
| <Link to={{ search: handleArrowClick(value) }}> |
src/components/PeopleFilters.tsx
Outdated
| className="button is-link is-outlined is-fullwidth" | ||
| href="#/people" | ||
| params={{ query: null, sex: null, centuries: null }} |
There was a problem hiding this comment.
Just pass new URLSearchParams(), it is too much work to reset each separately
src/components/PeopleFilters.tsx
Outdated
| 19 | ||
| </a> | ||
| {centuriesList.map(century => ( | ||
| <Link |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
StasSokolov
suggested changes
Dec 1, 2023
There was a problem hiding this comment.
Almost done, code looks good🔥
Check demo page please, sorting not working
https://github.com/mate-academy/react_people-table-advanced/assets/96830833/7633504b-0e81-4408-99da-c84c58a79be8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK