Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

completed the task #637

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

completed the task #637

wants to merge 3 commits into from

Conversation

mifyy
Copy link

@mifyy mifyy commented Dec 5, 2023

polosanya
polosanya suggested changes Dec 6, 2023
View reviewed changes
Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo link doesn't work(
image

src/components/PeoplePage.tsx Outdated
const data = await getPeople();

if (!data || data.length === 0) {
setErrorType('type1');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to use Enum instead of the hardcoded values

src/utils/FilterPeople.tsx

break;

case 'sex':
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@mifyy
Copy link
Author

mifyy commented Dec 6, 2023

I have made the corrections. Also, I've checked the demo link and I'm sure that it's correct. I don't know why it won't work.

StasSokolov
StasSokolov suggested changes Dec 7, 2023
View reviewed changes
Copy link

@StasSokolov StasSokolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo link also not working for me(

Снимок экрана 2023-12-07 в 11 41 29

@mifyy
Copy link
Author

mifyy commented Dec 7, 2023

Yep, it doesn't work for me too but I have no clue why. It seems to be correct, I'm out of ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StasSokolov StasSokolov StasSokolov requested changes

@polosanya polosanya polosanya requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mifyy @polosanya @StasSokolov @mithusddd