table_advansed #639
Closed
table_advansed #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBondarenko1982
suggested changes
Dec 6, 2023
There was a problem hiding this comment.
Looks good.
Compare your implementation with working example.
А couple mismatches founded.
- when exists some searchParams and click on person link - searchParams shouldn't be resetted
- when order in desc direction- should be visible only bottom arrow
actual:
working example:
src/components/PeopleFilters.tsx
Outdated
|
|
||
| const sex = searchParams.get('sex'); | ||
| const centuries = searchParams.getAll('centuries'); | ||
| const query = searchParams.get('query') || ''; |
There was a problem hiding this comment.
suggest to make enum for all possible searchParams
etojeDenys
suggested changes
Dec 8, 2023
src/components/PeoplePage.tsx
Outdated
Comment on lines
64
to
74
| case 'name': | ||
| { | ||
| prepared.sort((a, b) => a.name.localeCompare(b.name)); | ||
| break; | ||
| } | ||
|
|
||
| case 'sex': | ||
| { | ||
| prepared.sort((a, b) => a.sex.localeCompare(b.sex)); | ||
| break; | ||
| } |
There was a problem hiding this comment.
Suggested change
| case 'name': | |
| { | |
| prepared.sort((a, b) => a.name.localeCompare(b.name)); | |
| break; | |
| } | |
| case 'sex': | |
| { | |
| prepared.sort((a, b) => a.sex.localeCompare(b.sex)); | |
| break; | |
| } | |
| case 'name': | |
| case 'sex': | |
| { | |
| prepared.sort((a, b) => a[sort].localeCompare(b[sort])); | |
| break; | |
| } |
you can group some cases
src/components/PeoplePage.tsx
Outdated
Comment on lines
76
to
85
| case 'born': { | ||
| prepared.sort((a, b) => a.born - b.born); | ||
| break; | ||
| } | ||
|
|
||
| case 'died': { | ||
| prepared.sort((a, b) => a.died - b.died); | ||
| break; | ||
| } | ||
|
|
src/components/PeoplePage.tsx
Outdated
| setLoading(true); | ||
| getPeople() | ||
| .then(peopleOnServer) | ||
| .then(preparedPeople => setPeople(preparedPeople)) |
There was a problem hiding this comment.
Suggested change
| .then(preparedPeople => setPeople(preparedPeople)) | |
| .then(setPeople) |
we can simplify it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://maksymkos.github.io/react_people-table-advanced/