Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #560

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Develop #560

wants to merge 19 commits into from

Conversation

tonni004
Copy link

@tonni004 tonni004 commented Jan 7, 2025

volodymyr-soltys97
volodymyr-soltys97 suggested changes Jan 8, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Let's improve your code

  1. Fix width for buttons in the card, check it on the design
image
  1. You should open these additional links in the new tab
image
  1. These buttons should be on the same vertical line
image
  1. If we don't have any products here, then you don't need to show the number 0.
image
  1. Remove scroll when the menu is open
image

etojeDenys
etojeDenys approved these changes Jan 9, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonni004 @volodymyr-soltys97 @etojeDenys