Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

phoenixka4
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Tabs and App components! 🎉 Your code meets all the task requirements, and the functionality is spot on. The Tabs component handles props correctly, and the active tab logic is well-implemented. Keep up the excellent work! If you want to further enhance your skills, consider exploring additional best practices for even more robust code. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +22 to +25
<Tabs
tabs={tabs}
activeTabId={activeTabId}
onTabSelected={setActiveTabId}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the Tabs component is implemented to handle the props tabs, activeTabId, and onTabSelected correctly. The component should render a list of tabs, highlight the active tab, and call onTabSelected only when a non-active tab is clicked. Verify that these functionalities are implemented in the Tabs component as per the task description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants