Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1523

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

an-marryKyslenko
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

  1. When we delete all todos using the clear button, the loader is shown everywhere, we need to fix this and show only those todos that are deleted
image
  1. It is a bad practice to write all the code in one component, you need to separate the logic into different components, for example Header, Footer, TodoItem, TodoList

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the comments from the previous review still not fixed, if you need help feel free in the fe_chat
image

@@ -1748,7 +1748,7 @@ describe('', () => {
todos.assertTitle(0, 'New title');
});

it('should cancel if title was not changed', () => {
it.skip('should cancel if title was not changed', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to skip test

Suggested change
it.skip('should cancel if title was not changed', () => {
it('should cancel if title was not changed', () => {

@an-marryKyslenko
Copy link
Author

an-marryKyslenko commented Nov 22, 2024

I skiped one test becouse mentor from chat told me to do this.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!

src/App.tsx Outdated
// #endregion

// #region edit Todo
function editTodo(data: TodoTitleOrCompleted, todoId: number) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is important to follow the same way of creating functions everywhere, fix it everywhere

Suggested change
function editTodo(data: TodoTitleOrCompleted, todoId: number) {
сщтіе editTodo = (data: TodoTitleOrCompleted, todoId: number) => {

src/App.tsx Outdated
Comment on lines 83 to 85
// #endregion

// #region edit Todo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all comments

Suggested change
// #endregion
// #region edit Todo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants