-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #1523
base: master
Are you sure you want to change the base?
Develop #1523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Let's improve your code
- When we delete all todos using the clear button, the loader is shown everywhere, we need to fix this and show only those todos that are deleted
- It is a bad practice to write all the code in one component, you need to separate the logic into different components, for example
Header, Footer, TodoItem, TodoList
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1748,7 +1748,7 @@ describe('', () => { | |||
todos.assertTitle(0, 'New title'); | |||
}); | |||
|
|||
it('should cancel if title was not changed', () => { | |||
it.skip('should cancel if title was not changed', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to skip test
it.skip('should cancel if title was not changed', () => { | |
it('should cancel if title was not changed', () => { |
I skiped one test becouse mentor from chat told me to do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done!
src/App.tsx
Outdated
// #endregion | ||
|
||
// #region edit Todo | ||
function editTodo(data: TodoTitleOrCompleted, todoId: number) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is important to follow the same way of creating functions everywhere, fix it everywhere
function editTodo(data: TodoTitleOrCompleted, todoId: number) { | |
сщтіе editTodo = (data: TodoTitleOrCompleted, todoId: number) => { |
src/App.tsx
Outdated
// #endregion | ||
|
||
// #region edit Todo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all comments
// #endregion | |
// #region edit Todo |
DEMO LINK