add task solution #1524
Open
add task solution #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarasHoliuk
suggested changes
Nov 27, 2024
src/api/todos.ts
Outdated
| return client.post<Todo>('/todos', { userId, title, completed }); | ||
| }; | ||
|
|
||
| export const deleteTodos = (postId: number) => { |
There was a problem hiding this comment.
Suggested change
| export const deleteTodos = (postId: number) => { | |
| export const deleteTodo = (todoId: number) => { |
You delete (and add, update) only one todo
Also, it's not a post - it's todo)
src/api/todos.ts
Outdated
| return client.get<Todo[]>(`/todos?userId=${USER_ID}`); | ||
| }; | ||
|
|
||
| export const postTodos = ({ userId, title, completed }: Omit<Todo, 'id'>) => { |
There was a problem hiding this comment.
Suggested change
| export const postTodos = ({ userId, title, completed }: Omit<Todo, 'id'>) => { | |
| export const addTodo = ({ userId, title, completed }: Omit<Todo, 'id'>) => { |
you can name function depending on what does it do. It shouldn't reflect a request method in the name
src/App.tsx
Outdated
| }) | ||
| .catch(() => { | ||
| setErrorMessage('Unable to delete a todo'); | ||
| setTimeout(() => setErrorMessage(''), 3000); |
There was a problem hiding this comment.
You can create a separate useEffect for it - check if error exist - if yes setTimeout to clear it
src/components/Header.tsx
Outdated
| setTempTodo, | ||
| todosInProcess, | ||
| updateTodo, | ||
| newTitleTodo: newTodoTitle, |
There was a problem hiding this comment.
nit: you can name props like it instead of renaming
src/App.tsx
Outdated
| @@ -1,26 +1,158 @@ | |||
| /* eslint-disable max-len */ | |||
| /* eslint-disable react-hooks/rules-of-hooks */ | |||
There was a problem hiding this comment.
Why do you need to disable this rule? Better not do it and figure the problem out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK