Develop #1526
Open
Develop #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Nov 30, 2024
There was a problem hiding this comment.
-
show loader on all todos on clear completed
-
you don't need to call getTodos after clear completed logic, it looks redundant
https://github.com/user-attachments/assets/6625ff57-c929-417f-8fdb-5f62bf42b53b -
you don't need to show the loader in this case
Screen.Recording.2024-11-30.at.11.34.25.mov
| const [updatingStatusIds, setUpdatingStatusIds] = useState<Set<number>>( | ||
| new Set(), | ||
| ); | ||
| const [allCompleted, setAllCompleted] = useState(false); |
Comment on lines
+179
to
+184
| useEffect(() => { | ||
| const IsAllCompleted = todos.every(todo => todo.completed); | ||
|
|
||
| setAllCompleted(IsAllCompleted); | ||
| }, [todos]); | ||
|
|
There was a problem hiding this comment.
Suggested change
| useEffect(() => { | |
| const IsAllCompleted = todos.every(todo => todo.completed); | |
| setAllCompleted(IsAllCompleted); | |
| }, [todos]); | |
| const isAllCompleted = todos.every(todo => todo.completed); |
anastasiiavorobiova
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK