task solution_v1 #1530
Open
task solution_v1 #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests closed locally, but GitHub shows problems with lint and tests... |
volodymyr-soltys97
suggested changes
Dec 4, 2024
volodymyr-soltys97
suggested changes
Dec 11, 2024
src/App.tsx
Outdated
Comment on lines
230
to
260
| {todos.length !== 0 && ( | ||
| <footer className="todoapp__footer" data-cy="Footer"> | ||
| <span className="todo-count" data-cy="TodosCounter"> | ||
| {`${activeTodos} items left`} | ||
| </span> | ||
|
|
||
| <nav className="filter" data-cy="Filter"> | ||
| {Object.values(FilterOptions).map(option => ( | ||
| <a | ||
| key={option} | ||
| href={`#/${option}`} | ||
| className={classNames('filter__link', { | ||
| selected: currentFilter === option, | ||
| })} | ||
| data-cy={`FilterLink${option}`} | ||
| onClick={() => setCurrentFilter(option)} | ||
| > | ||
| {option} | ||
| </a> | ||
| ))} | ||
| </nav> | ||
|
|
||
| <button | ||
| type="button" | ||
| className="todoapp__clear-completed" | ||
| data-cy="ClearCompletedButton" | ||
| onClick={() => handleClearCompleted()} | ||
| disabled={todos.every(todo => !todo.completed) || loading} | ||
| > | ||
| Clear completed | ||
| </button> |
There was a problem hiding this comment.
Move this logic to the Footer component
| data-cy="statusSelect" | ||
| onChange={element => setFilter(element.target.value)} | ||
| > | ||
| <option value={FilterOptions.All}>All</option> |
There was a problem hiding this comment.
Also use enum here
Suggested change
| <option value={FilterOptions.All}>All</option> | |
| <option value={FilterOptions.All}>{FilterOptions.All}</option> |
|
Finally, I found my mistake with double rendering!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://inesshtepa.github.io/react_todo-app-with-api/