-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #1536
base: master
Are you sure you want to change the base?
solution #1536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Thanks for the great work — everything looks good to me! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments, but I'm approving it
useEffect(() => { | ||
if (!isFocused) { | ||
field.current?.focus(); | ||
} | ||
}, [isFocused]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useEffect(() => { | |
if (!isFocused) { | |
field.current?.focus(); | |
} | |
}, [isFocused]); | |
useEffect(() => { | |
if (!isFocused || isDeleted) { | |
field.current?.focus(); | |
} | |
}, [isFocused, isDeleted]); |
useEffect(() => { | ||
if (isDeleted) { | ||
field.current?.focus(); | ||
} | ||
}, [isDeleted]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this useEffect
DEMO LINK