solution #1540
Open
solution #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniil-102
approved these changes
Dec 19, 2024
| return () => { | ||
| clearTimeout(timeoutId); | ||
| }; | ||
| }, [error]); |
There was a problem hiding this comment.
React Hook useEffect has a missing dependency: 'handleErrorClose'. Either include it or remove the dependency array
VolodymyrKirichenko
approved these changes
Dec 20, 2024
| setErrorTodos(ErrorType.NoErrors); | ||
| }, []); | ||
|
|
||
| const visibleTodos = todos.filter(todo => { |
src/App.tsx
Outdated
Comment on lines
45
to
47
| const activeTodosCount = todos.filter(todo => !todo.completed).length; | ||
|
|
||
| const completedTodos = todos.filter(todo => todo.completed); |
src/App.tsx
Outdated
Comment on lines
62
to
126
| const onAddTodo = async (newTodo: Omit<Todo, 'id'>): Promise<void> => { | ||
| try { | ||
| const createdTodo = await createTodo(newTodo); | ||
|
|
||
| setTodos(currentTodos => [...currentTodos, createdTodo]); | ||
| } catch (error) { | ||
| setErrorTodos(ErrorType.Add); | ||
| throw error; | ||
| } | ||
| }; | ||
|
|
||
| const onDeleteTodo = async (todoId: number) => { | ||
| setLoadingTodosIds(currentIds => [...currentIds, todoId]); | ||
| try { | ||
| await deleteTodo(todoId); | ||
| setTodos(currentTodos => currentTodos.filter(todo => todo.id !== todoId)); | ||
| } catch (error) { | ||
| setErrorTodos(ErrorType.Delete); | ||
| throw error; | ||
| } finally { | ||
| setLoadingTodosIds(currentIds => currentIds.filter(id => id !== todoId)); | ||
| } | ||
| }; | ||
|
|
||
| const onDeleteAllCompleted = () => { | ||
| completedTodos.forEach(completedTodo => { | ||
| onDeleteTodo(completedTodo.id); | ||
| }); | ||
| }; | ||
|
|
||
| const onUpdateTodo = async (newTodo: Todo) => { | ||
| setLoadingTodosIds(currentIds => [...currentIds, newTodo.id]); | ||
| try { | ||
| const updatedTodo = await updateTodo(newTodo); | ||
|
|
||
| setTodos(currentTodos => | ||
| currentTodos.map(todo => { | ||
| return todo.id === updatedTodo.id ? updatedTodo : todo; | ||
| }), | ||
| ); | ||
| } catch (error) { | ||
| setErrorTodos(ErrorType.Update); | ||
| throw error; | ||
| } finally { | ||
| setLoadingTodosIds(currentIds => | ||
| currentIds.filter(id => id !== newTodo.id), | ||
| ); | ||
| } | ||
| }; | ||
|
|
||
| const onUpdateToggleAll = () => { | ||
| todos.forEach(todo => { | ||
| if (todos.length === completedTodos.length) { | ||
| onUpdateTodo({ ...todo, completed: false }); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| if (todo.completed === false) { | ||
| onUpdateTodo({ ...todo, completed: true }); | ||
|
|
||
| return; | ||
| } | ||
| }); | ||
| }; |
There was a problem hiding this comment.
useCallback for all the cases?
src/App.tsx
Outdated
| onUpdateToggleAll={onUpdateToggleAll} | ||
| /> | ||
|
|
||
| {todos.length > 0 && ( |
There was a problem hiding this comment.
better option(it will be converted to boolean value)
Suggested change
| {todos.length > 0 && ( | |
| {!!todos.length && ( |
src/components/Footer/Footer.tsx
Outdated
| {Object.values(FilterType).map(filter => ( | ||
| <a | ||
| key={filter} | ||
| href={`#/${filter === FilterType.All ? '' : filter.toLowerCase()}`} |
There was a problem hiding this comment.
better or no?what do u think? 🤔
Suggested change
| href={`#/${filter === FilterType.All ? '' : filter.toLowerCase()}`} | |
| href={`#/${filter !== FilterType.All && filter.toLowerCase()}`} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK