Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1549

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

solution #1549

wants to merge 6 commits into from

Conversation

schyrva
Copy link

@schyrva schyrva commented Dec 19, 2024

src/App.tsx Outdated
todosLength={todos.length}
/>

{(todos.length > 0 || tempTodo) && (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also can use this syntax

  •    {todos.length > 0 && (
    
  •    {!!todos.length && (
    

Copy link

@chelsea7smile chelsea7smile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it, but fix small moments (based on mentor's recommendations from my experience)

src/App.tsx Outdated
[todos],
);

const onAddTodo = async (todoTitle: string) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use name naming conventions for all cases like that (on>handle)

const onAddTodo = async (todoTitle: string) => {

const handleAddTodo = async (todoTitle: string) => {

Copy link

@VolodymyrKirichenko VolodymyrKirichenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, but review my comments and fix them 🥹

src/App.tsx Outdated Show resolved Hide resolved
src/components/TodoFooter/TodoFooter.tsx Show resolved Hide resolved
src/components/TodoHeader/TodoHeader.tsx Show resolved Hide resolved
src/components/TodoHeader/TodoHeader.tsx Outdated Show resolved Hide resolved
src/components/TodoItem/TodoItem.tsx Outdated Show resolved Hide resolved
src/components/TodoItem/TodoItem.tsx Outdated Show resolved Hide resolved
src/api/todos.ts Outdated Show resolved Hide resolved
src/api/todos.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants