-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #1555
base: master
Are you sure you want to change the base?
solution #1555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍
todos.filter(todo => { | ||
if (filterStatus === FilterStatus.All) { | ||
return true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to filter at all when filterStatus === FilterStatus.All
{todosLeft} items left | ||
</span> | ||
|
||
{/* Active link should have the 'selected' class */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all comments
const onBlur = async (event: React.FocusEvent<HTMLInputElement, Element> | React.FormEvent<HTMLFormElement>, | ||
) => { | ||
event.preventDefault(); | ||
const normalizedTitle = todoTitleValue.trim(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 4 spaces but found 6
DEMO LINK