solution #1562
Open
solution #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BudnikOleksii
suggested changes
Dec 23, 2024
src/App.tsx
Outdated
| <div className="todoapp"> | ||
| <h1 className="todoapp__title">todos</h1> | ||
|
|
||
| <header className="todoapp__header"> |
src/App.tsx
Outdated
| <h1 className="todoapp__title">todos</h1> | ||
|
|
||
| <header className="todoapp__header"> | ||
| {/* this button should have `active` class only if all todos are completed */} |
src/App.tsx
Outdated
| </header> | ||
|
|
||
| <div className="todoapp__content"> | ||
| <section className="todoapp__main" data-cy="TodoList"> |
src/App.tsx
Outdated
| </div> | ||
|
|
||
| <div | ||
| data-cy="ErrorNotification" |
There was a problem hiding this comment.
Create ErrorNotification component
|
|
||
| export const TodoFilter: React.FC<Props> = memo( | ||
| ({ filter, onFilterChange, todos, onDelete }) => { | ||
| const statuses = [ |
There was a problem hiding this comment.
Move this constant outside the component
added 2 commits
December 27, 2024 16:07
StasSokolov1
suggested changes
Dec 27, 2024
src/App.tsx
Outdated
|
|
||
| const handleError = useCallback((error: ErrorType) => { | ||
| setErrorMsg(error); | ||
| setTimeout(() => setErrorMsg(ErrorType.Default), 3000); |
There was a problem hiding this comment.
please don't forget to clear setTimeout
| export const USER_ID = 2176; | ||
|
|
||
| export const getTodos = () => { | ||
| return client.get<Todo[]>(`/todos?userId=${USER_ID}`); |
There was a problem hiding this comment.
let's move /todos into const and reuse
|
|
||
| export const TodoFilter: React.FC<Props> = memo( | ||
| ({ filter, onFilterChange, todos, onDelete }) => { | ||
| const statuses = [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK