Done #1572
Open
Done #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Dec 27, 2024
README.md
Outdated
| @@ -47,4 +47,4 @@ Implement the ability to edit a todo title on double click: | |||
|
|
|||
| - Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline). | |||
| - Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript). | |||
| - Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_todo-app-with-api/) and add it to the PR description. | |||
| - Replace `<your_account>` with your Github username in the [DEMO LINK](https:/IrynaMariiko00.github.io/react_todo-app-with-api/) and add it to the PR description. | |||
There was a problem hiding this comment.
The demo link in the PR description is wrong now, add link from this file
etojeDenys
suggested changes
Dec 27, 2024
src/App.tsx
Outdated
Comment on lines
119
to
123
| useEffect(() => { | ||
| const allCompleted = todos.every(todo => todo.completed); | ||
|
|
||
| setIsToggleAllActive(allCompleted); | ||
| }, [todos]); |
There was a problem hiding this comment.
Suggested change
| useEffect(() => { | |
| const allCompleted = todos.every(todo => todo.completed); | |
| setIsToggleAllActive(allCompleted); | |
| }, [todos]); | |
| const isToggleAllActive = todos.every(todo => todo.completed); |
just can be a var
added 2 commits
December 27, 2024 12:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK