todo app final part #781
Open
todo app final part #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBodnar
suggested changes
Sep 21, 2023
src/TodoContext.tsx
Outdated
| @@ -0,0 +1,92 @@ | |||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
src/components/Header/Header.tsx
Outdated
Comment on lines
74
to
78
| const sortAllInSelect = todos.filter(({ completed }) => !completed); | ||
|
|
||
| preparedList = sortAllInSelect.map(item => { | ||
| return { ...item, completed: true }; | ||
| }); |
There was a problem hiding this comment.
you can combine map and filter with using method reduce
src/components/Todo/Todo.tsx
Outdated
Comment on lines
53
to
57
| if (updatedTitle) { | ||
| updatedTodo = { ...todo, title: updatedTitle }; | ||
| } else { | ||
| updatedTodo = { ...todo, completed: !completed }; | ||
| } |
There was a problem hiding this comment.
make sense to use ternary operator here as it will make a code shorter
src/components/Todo/Todo.tsx
Outdated
Comment on lines
62
to
69
| setTodos(currentTodos => { | ||
| const newTodos = [...currentTodos]; | ||
| const index = newTodos.findIndex(item => item.id === updatedTodo.id); | ||
|
|
||
| newTodos.splice(index, 1, updatedTodo); | ||
|
|
||
| return newTodos; | ||
| }); |
There was a problem hiding this comment.
you use method filter here and it will make a code shorter
src/components/Todo/Todo.tsx
Outdated
| setIsLoading(false); | ||
| setIsEditMode(false); | ||
| } catch { | ||
| setIsLoading(false); |
There was a problem hiding this comment.
- you need to call setIsLoading only once in block finally
src/components/Todo/Todo.tsx
Outdated
| )} | ||
|
|
||
| <div className={cn('modal overlay', { | ||
| 'is-active': isLoading || selectedAreDeleting(), |
There was a problem hiding this comment.
please don't call a function from the template because it will be executed every time when the state change, so make sense to move it to the variable
src/components/TodoList/TodoList.tsx
Outdated
| <span className="todo__title">{tempTodo.title}</span> | ||
| <button type="button" className="todo__remove">×</button> | ||
|
|
||
| {/* 'is-active' class puts this modal on top of the todo */} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK