add task solution #797
Open
add task solution #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BudnikOleksii
suggested changes
Sep 27, 2023
BudnikOleksii
suggested changes
Oct 3, 2023
src/App.tsx
Outdated
|
|
||
| const USER_ID = 0; | ||
| const filterTodos = (todos: Todo[], filterStatus: Status): Todo[] => { |
src/App.tsx
Outdated
| .catch(() => { | ||
| setErrorMessage(ErrorMessages.UnableAddTodo); | ||
| setTempTodo(null); | ||
| throw new Error(); |
There was a problem hiding this comment.
You don't need to throw an error here as you handle errors in this block
src/App.tsx
Outdated
Comment on lines
102
to
107
| TodoSevise.updateTodo({ | ||
| id: todo.id, | ||
| title: newTitle, | ||
| userId: todo.userId, | ||
| completed: todo.completed, | ||
| }) |
There was a problem hiding this comment.
Suggested change
| TodoSevise.updateTodo({ | |
| id: todo.id, | |
| title: newTitle, | |
| userId: todo.userId, | |
| completed: todo.completed, | |
| }) | |
| TodoSevise.updateTodo({ | |
| ...todo, | |
| title: newTitle, | |
| }) |
src/App.tsx
Outdated
Comment on lines
121
to
126
| TodoSevise.updateTodo({ | ||
| id: todo.id, | ||
| title: todo.title, | ||
| userId: todo.userId, | ||
| completed: !todo.completed, | ||
| }) |
src/App.tsx
Outdated
Comment on lines
172
to
196
| <section className="todoapp__main" data-cy="TodoList"> | ||
| {visibleTodos.map(todo => ( | ||
| <TodoItem | ||
| todo={todo} | ||
| onTodoDelete={handleDeleteTodo} | ||
| isLoading={isLoading} | ||
| handleLoading={handleLoading} | ||
| key={todo.id} | ||
| onTodoUpdate={handleUpdateTodo} | ||
| onToggleChange={handleToggleChange} | ||
| /> | ||
| ))} | ||
|
|
||
| {(tempTodo) && ( | ||
| <TodoItem | ||
| todo={tempTodo} | ||
| onTodoDelete={handleDeleteTodo} | ||
| isLoading={isLoading} | ||
| handleLoading={handleLoading} | ||
| onTodoUpdate={handleUpdateTodo} | ||
| onToggleChange={handleToggleChange} | ||
| key={tempTodo.id} | ||
| /> | ||
| )} | ||
| </section> |
src/App.tsx
Outdated
Comment on lines
210
to
212
| <div | ||
| data-cy="ErrorNotification" | ||
| className={classNames( |
There was a problem hiding this comment.
Create an ErrorNotification component, and also move related logic to it too, this one:
src/components/Header.tsx
Outdated
| setTodoTitle: (value: string) => void; | ||
| }; | ||
|
|
||
| const USER_ID = 11516; |
There was a problem hiding this comment.
I see this constant created in the API too. It must be only one USER_ID, move it constants and use it
BudnikOleksii
suggested changes
Oct 5, 2023
There was a problem hiding this comment.
Looks better, but you should get rid of all comments and there are still no loaders when the user changes the todo status
https://www.loom.com/share/b891778c03f74e2f9d8f14c3546b0014?sid=17028e00-2bb8-43b2-b192-005624336478
src/App.tsx
Outdated
|
|
||
| const USER_ID = 0; | ||
| import React, { useEffect, useRef, useState } from 'react'; | ||
| // import classNames from 'classnames'; |
src/App.tsx
Outdated
Comment on lines
43
to
53
| /* const timerId: React.MutableRefObject<number> = useRef<number>(0); | ||
|
|
||
| useEffect(() => { | ||
| if (timerId.current) { | ||
| window.clearTimeout(timerId.current); | ||
| } | ||
|
|
||
| timerId.current = window.setTimeout(() => { | ||
| setErrorMessage(''); | ||
| }, 3000); | ||
| }, [errorMessage]); */ |
There was a problem hiding this comment.
Get rid of all comments in your code
src/components/TodoItem.tsx
Outdated
Comment on lines
77
to
78
| <> | ||
| <div |
There was a problem hiding this comment.
As you have only one element in a row you don't need to use the react fragment
src/components/TodoItem.tsx
Outdated
Comment on lines
142
to
144
| </div> | ||
|
|
||
| </div> |
There was a problem hiding this comment.
Don't leave blank lines between parent and child components
BudnikOleksii
approved these changes
Oct 6, 2023
| .catch(() => { | ||
| setErrorMessage(ErrorMessages.UnableAddTodo); | ||
| setTempTodo(null); | ||
| // throw new Error(); |
Comment on lines
+159
to
+183
| {/* <section className="todoapp__main" data-cy="TodoList"> | ||
| {visibleTodos.map(todo => ( | ||
| <TodoItem | ||
| todo={todo} | ||
| onTodoDelete={handleDeleteTodo} | ||
| isLoading={isLoading} | ||
| handleLoading={handleLoading} | ||
| key={todo.id} | ||
| onTodoUpdate={handleUpdateTodo} | ||
| onToggleChange={handleToggleChange} | ||
| /> | ||
| ))} | ||
|
|
||
| {(tempTodo) && ( | ||
| <TodoItem | ||
| todo={tempTodo} | ||
| onTodoDelete={handleDeleteTodo} | ||
| isLoading={isLoading} | ||
| handleLoading={handleLoading} | ||
| onTodoUpdate={handleUpdateTodo} | ||
| onToggleChange={handleToggleChange} | ||
| key={tempTodo.id} | ||
| /> | ||
| )} | ||
| </section> */} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK