Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #799

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Solution #799

wants to merge 15 commits into from

Conversation

Sancz0pansa
Copy link

src/App.tsx Outdated Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the code belongs to global state - this should not be in App.tsx file

src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/components/TempTodo.tsx Outdated Show resolved Hide resolved
src/components/TodoItem.tsx Outdated Show resolved Hide resolved
src/components/TodoList.tsx Outdated Show resolved Hide resolved
@Sancz0pansa
Copy link
Author

I had a Q&A and we didn't figure out why the tests weren't passing.

@Sancz0pansa Sancz0pansa requested a review from choeqq September 27, 2023 13:13
Copy link

@ogospadzipalina ogospadzipalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link

@choeqq choeqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants