add working version #813
Open
add working version #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BudnikOleksii
suggested changes
Sep 29, 2023
src/App.tsx
Outdated
Comment on lines
69
to
94
| <div | ||
| data-cy="ErrorNotification" | ||
| className={cn( | ||
| 'notification is-danger is-light has-text-weight-normal', { | ||
| hidden: !errorMessage, | ||
| }, | ||
| )} | ||
| > | ||
| <button | ||
| data-cy="HideErrorButton" | ||
| type="button" | ||
| className="delete" | ||
| onClick={() => setErrorMessage('')} | ||
| /> | ||
| {/* show only one message at a time */} | ||
| {errorMessage} | ||
| {/* Unable to load todos | ||
| <br /> | ||
| Title should not be empty | ||
| <br /> | ||
| Unable to add a todo | ||
| <br /> | ||
| Unable to delete a todo | ||
| <br /> | ||
| Unable to update a todo */} | ||
| </div> |
There was a problem hiding this comment.
Remove comments, create a separate ErrorNotification component, and move related logic and useEffect to it
src/components/TodoFilter.tsx
Outdated
Comment on lines
6
to
23
| const setFilterHref = (filter: TodosFilter) => { | ||
| switch (filter) { | ||
| case TodosFilter.Active: | ||
| return '#/active'; | ||
|
|
||
| case TodosFilter.Completed: | ||
| return '#/completed'; | ||
|
|
||
| case TodosFilter.All: | ||
| default: | ||
| return '#/'; | ||
| } | ||
| }; | ||
|
|
||
| const setFilterDataCy = (filter: TodosFilter) => { | ||
| switch (filter) { | ||
| case TodosFilter.Active: | ||
| return 'FilterLinkActive'; |
There was a problem hiding this comment.
You do the same checks so you can return an object and one function is enough in this case.
case TodosFilter.Active:
return {
href: '#/active',
dataCy: 'FilterLinkActive',
};
src/components/TodoFilter.tsx
Outdated
|
|
||
| return ( | ||
| <footer className="todoapp__footer" data-cy="Footer"> | ||
| {/* Hide the footer if there are no todos */} |
src/components/TodoForm.tsx
Outdated
Comment on lines
56
to
58
| .catch(() => { | ||
|
|
||
| }) |
There was a problem hiding this comment.
Why catch block is empty? Notify a user in case of error
alexander-ignatow
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK