togle completed, allTodoCompleted, esc #818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-mirzoian
suggested changes
Sep 28, 2023
There was a problem hiding this comment.
Good job, but there is quite a bit of work to be done.
You can also now add empty spaces to the title and Todo will not be deleted:
https://gyazo.com/03789f47a4c408f21448fa4e77eae3c5
…ndleToggleTodo&hadleAddTodo async
roman-mirzoian
suggested changes
Oct 2, 2023
There was a problem hiding this comment.
Good fixed, but this bug still not fixed:
You can also now add empty spaces to the title and Todo will not be deleted:
https://gyazo.com/03789f47a4c408f21448fa4e77eae3c5
Moroz-Dmytro
suggested changes
Oct 3, 2023
Moroz-Dmytro
approved these changes
Oct 4, 2023
| }, 3000)); | ||
| }, [errorMessage, errorTimer]); | ||
|
|
||
| const hasTodos = !!todos.length; |
There was a problem hiding this comment.
This variable is not really needed
|
|
||
| setIsEditing(false); | ||
| } catch { | ||
| // |
| import { Todo } from '../types/Todo'; | ||
| import { ForComletedTodo } from '../types/enumFilter'; | ||
|
|
||
| export const filterTodos = ( |
There was a problem hiding this comment.
Suggested change
| export const filterTodos = ( | |
| export const getFilteredTodos = ( |
| @@ -0,0 +1,5 @@ | |||
| export enum ForComletedTodo { | |||
There was a problem hiding this comment.
Suggested change
| export enum ForComletedTodo { | |
| export enum TodoStatus { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK