Develop #1039
Open
Develop #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Aug 14, 2024
SanyaBratashchuk
approved these changes
Aug 15, 2024
src/App.tsx
Outdated
| const { todos, inputValue, filterStatus } = useContext(StateContext); | ||
| const dispatch = useContext(DispatchContext); | ||
|
|
||
| const inputElement = useRef<HTMLInputElement>(null); |
There was a problem hiding this comment.
Suggested change
| const inputElement = useRef<HTMLInputElement>(null); | |
| const inputElementRef = useRef<HTMLInputElement>(null); |
src/App.tsx
Outdated
Comment on lines
16
to
29
| const filteredTodos = todos.filter(todo => { | ||
| const { completed } = todo; | ||
|
|
||
| switch (filterStatus) { | ||
| case Filter.Active: | ||
| return !completed; | ||
|
|
||
| case Filter.Completed: | ||
| return completed; | ||
|
|
||
| default: | ||
| return todo; | ||
| } | ||
| }); |
There was a problem hiding this comment.
move filter inside switch case not vice versa. To avoid redundant iteration in default case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
Sorry, I accidentally made a pull request to the wrong branch, for some reason my pull request was made to the "develop" branch. I closed the wrong pull request