solution #1043
Open
solution #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanyaBratashchuk
suggested changes
Aug 20, 2024
volodymyr-soltys97
suggested changes
Aug 21, 2024
src/App.tsx
Outdated
| {!!todos.length && ( | ||
| <footer className="todoapp__footer" data-cy="Footer"> | ||
| <span className="todo-count" data-cy="TodosCounter"> | ||
| {`${activeTodos.length} item${activeTodos.length !== 1 ? 's' : ''} left`} |
There was a problem hiding this comment.
Move this logic from jsx to the helper variable and use it here
src/components/TodoFilter.tsx
Outdated
Comment on lines
24
to
26
| {filterParams.map(param => { | ||
| return ( | ||
| <a |
There was a problem hiding this comment.
Suggested change
| {filterParams.map(param => { | |
| return ( | |
| <a | |
| {filterParams.map(param => ( | |
| <a |
src/services/TodoService.ts
Outdated
Comment on lines
13
to
16
| case 'Active': | ||
| return todos.filter(todo => !todo.completed); | ||
| case 'Completed': | ||
| return todos.filter(todo => todo.completed); |
There was a problem hiding this comment.
Create a enum for 'All', 'Active', 'Completed' and use it everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK