Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add solution #1045

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add solution #1045

wants to merge 2 commits into from

Conversation

reznik-denis
Copy link

etojeDenys
etojeDenys suggested changes Aug 22, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. do not show clear completed button if we don't have completed todos
image
  1. delete todo if editing input has only spaces
  2. delete todo if editing input is empty
image

@reznik-denis
Copy link
Author

I can't fix first issue because test demades from me to disables CleadCompleted only, not hide. Other issues I've fixed.

volodymyr-soltys97
volodymyr-soltys97 approved these changes Aug 23, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🔥

src/components/TodoFromList.tsx
/>
</label>

{(isEditTodo === null || isEditTodo[id] === undefined) && (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{(isEditTodo === null || isEditTodo[id] === undefined) && (
{(!isEditTodo || !isEditTodo[id]) && (

src/components/TodoFromList.tsx
</button>
</>
)}
{isEditTodo !== null && isEditTodo[id] && (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{isEditTodo !== null && isEditTodo[id] && (
{isEditTodo && isEditTodo[id] && (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reznik-denis @volodymyr-soltys97 @etojeDenys