Develop #1056
Open
Develop #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanyaBratashchuk
suggested changes
Oct 2, 2024
src/components/TodoList.tsx
Outdated
Comment on lines
19
to
26
| switch (filter) { | ||
| case Filter.ACTIVE: | ||
| return !todo.completed; | ||
| case Filter.COMPLETED: | ||
| return todo.completed; | ||
| default: | ||
| return true; | ||
| } |
There was a problem hiding this comment.
move filter inside swith to avoid extra iteration in default case
etojeDenys
suggested changes
Oct 3, 2024
src/components/header.tsx
Outdated
Comment on lines
30
to
41
| useEffect(() => { | ||
| const savedTodos = localStorage.getItem('todos'); | ||
|
|
||
| if (savedTodos) { | ||
| setTodos(JSON.parse(savedTodos)); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| localStorage.setItem('todos', JSON.stringify(todos)); | ||
| }, [todos]); |
There was a problem hiding this comment.
why do you need it in the header, move into state.tsx
volodymyr-soltys97
suggested changes
Oct 3, 2024
src/components/TodoList.tsx
Outdated
| ); | ||
| } | ||
|
|
||
| function handleUpdateTodo(id: number, newTitle: string) { |
There was a problem hiding this comment.
It is important to stick to one way of creating functions, fix it everywhere
Suggested change
| function handleUpdateTodo(id: number, newTitle: string) { | |
| const handleUpdateTodo = (id: number, newTitle: string) => { |
src/components/TodoList.tsx
Outdated
| {filteredTodos.map((todo: Todo) => ( | ||
| <div | ||
| data-cy="Todo" | ||
| className={`todo ${todo.completed ? 'completed' : ''}`} |
There was a problem hiding this comment.
Use the classnames library for add classes with condition. Fix it everywhere
There was a problem hiding this comment.
why i need use this lebrary? for me vanilla is better =)
src/components/footer.tsx
Outdated
Comment on lines
29
to
54
| <a | ||
| href="#/" | ||
| className={`filter__link ${filter === Filter.ALL ? 'selected' : ''}`} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => handleFilterChange(Filter.ALL)} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={`filter__link ${filter === Filter.ACTIVE ? 'selected' : ''}`} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => handleFilterChange(Filter.ACTIVE)} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={`filter__link ${filter === Filter.COMPLETED ? 'selected' : ''}`} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => handleFilterChange(Filter.COMPLETED)} | ||
| > | ||
| Completed | ||
| </a> |
There was a problem hiding this comment.
Use Object.values(your enum) and render these options with map() method
| className="todo__title" | ||
| onDoubleClick={() => setEditingTodoId(todo.id)} | ||
| > | ||
| {todo.title} |
src/components/header.tsx
Outdated
Comment on lines
35
to
44
| onClick={() => { | ||
| const allCompleted = todos.every((todo: Todo) => todo.completed); | ||
|
|
||
| setTodos((currentTodos: Todo[]) => | ||
| currentTodos.map((todo: Todo) => ({ | ||
| ...todo, | ||
| completed: !allCompleted, | ||
| })), | ||
| ); | ||
| }} |
There was a problem hiding this comment.
Move this logic to the handler function
src/components/state.tsx
Outdated
Comment on lines
51
to
62
| value={{ | ||
| todos, | ||
| setTodos, | ||
| title, | ||
| setTitle, | ||
| filter, | ||
| setFilter, | ||
| editingTodoId, | ||
| setEditingTodoId, | ||
| deleteTodo, | ||
| inputRef, | ||
| }} |
There was a problem hiding this comment.
Move these values to the object and pass it here
etojeDenys
suggested changes
Oct 3, 2024
src/components/footer.tsx
Outdated
|
|
||
| return ( | ||
| <> | ||
| {todos.length > 0 ? ( |
There was a problem hiding this comment.
Suggested change
| {todos.length > 0 ? ( | |
| {todos.length > 0 && ( |
src/components/TodoList.tsx
Outdated
| {filteredTodos.map((todo: Todo) => ( | ||
| <div | ||
| data-cy="Todo" | ||
| className={`todo ${todo.completed ? 'completed' : ''}`} |
There was a problem hiding this comment.
Suggested change
| className={`todo ${todo.completed ? 'completed' : ''}`} | |
| className={cn('todo', {'completed':todo.completed})} |
it's looks much better
also if we will need to add some another class here
without classnames:
className={`todo ${todo.completed ? 'completed' : ''} ${smth ? 'test-class' : ''}`}
with classnames:
className={cn('todo', {'completed':todo.completed, 'test-class': smth})}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK