Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo app completed #1075

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

todo app completed #1075

wants to merge 6 commits into from

Conversation

MaksymMohyla
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 6, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, your demo link is empty now, you need to fix it
image

@MaksymMohyla MaksymMohyla reopened this Nov 6, 2024
volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 7, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Let's improve your code
You need to fix the input width. Check it on the working example
image
image

src/components/TodoList/TodoItem/TodoItem.tsx Outdated
className="todo__title"
onDoubleClick={handleSelectTodo}
>
{todo.title}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use destructuring for todo

anastasiiavorobiova
anastasiiavorobiova approved these changes Nov 7, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaksymMohyla @volodymyr-soltys97 @anastasiiavorobiova