Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1081

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #1081

wants to merge 2 commits into from

Conversation

imondok03
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's make your code better

src/index.tsx Outdated
Comment on lines 4 to 6
// import './styles/todo.scss';
// import './styles/todoapp.scss';
// import './styles/filter.scss';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all comments

Suggested change
// import './styles/todo.scss';
// import './styles/todoapp.scss';
// import './styles/filter.scss';

Comment on lines 1 to 5
export enum TodoStatus {
all = 'All',
active = 'Active',
completed = 'Completed',
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to duplicate enums with the same values, use only one enum
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants