-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #1082
base: master
Are you sure you want to change the base?
Develop #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Let's make your code better
src/UserWarning.tsx
Outdated
import React from 'react'; | ||
|
||
export const UserWarning: React.FC = () => ( | ||
<section className="section"> | ||
<p className="box is-size-3"> | ||
Please get your <b> userId </b>{' '} | ||
<a href="https://mate-academy.github.io/react_student-registration"> | ||
here | ||
</a>{' '} | ||
and save it in the app <pre>const USER_ID = ...</pre> | ||
All requests to the API must be sent with this | ||
<b> userId.</b> | ||
</p> | ||
</section> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/api/todos.ts
Outdated
// Your userId is 1414 | ||
// Please use it for all your requests to the Students API. For example: | ||
// https://mate.academy/students-api/todos?userId=1414 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all comments
src/components/TodoItem.tsx
Outdated
|
||
focusInput(inputRef); | ||
} | ||
} else if (newTitle.trim() !== todo.title) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} else if (newTitle.trim() !== todo.title) { | |
} else if (newTitle.trim() !== title) { |
type="button" | ||
className="todo__remove" | ||
data-cy="TodoDelete" | ||
onClick={() => handleDeleteTodo(todo.id)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onClick={() => handleDeleteTodo(todo.id)} | |
onClick={() => handleDeleteTodo(id)} |
import 'bulma/css/bulma.css'; | ||
import '@fortawesome/fontawesome-free/css/all.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
https://tania-kuzmenko.github.io/react_todo-app/