Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1082

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #1082

wants to merge 3 commits into from

Conversation

tania-kuzmenko
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's make your code better

Comment on lines 1 to 15
import React from 'react';

export const UserWarning: React.FC = () => (
<section className="section">
<p className="box is-size-3">
Please get your <b> userId </b>{' '}
<a href="https://mate-academy.github.io/react_student-registration">
here
</a>{' '}
and save it in the app <pre>const USER_ID = ...</pre>
All requests to the API must be sent with this
<b> userId.</b>
</p>
</section>
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this component
image

src/api/todos.ts Outdated
Comment on lines 4 to 6
// Your userId is 1414
// Please use it for all your requests to the Students API. For example:
// https://mate.academy/students-api/todos?userId=1414

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all comments


focusInput(inputRef);
}
} else if (newTitle.trim() !== todo.title) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} else if (newTitle.trim() !== todo.title) {
} else if (newTitle.trim() !== title) {

type="button"
className="todo__remove"
data-cy="TodoDelete"
onClick={() => handleDeleteTodo(todo.id)}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onClick={() => handleDeleteTodo(todo.id)}
onClick={() => handleDeleteTodo(id)}

Comment on lines +3 to +4
import 'bulma/css/bulma.css';
import '@fortawesome/fontawesome-free/css/all.css';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to change imports
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants