Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1094

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #1094

wants to merge 4 commits into from

Conversation

maxmodrr
Copy link

@maxmodrr maxmodrr commented Jan 5, 2025

DEMO LINK

Didn`t pass one test:

  • should not have todos in localStorage
    Idk how to pass it, asked for a help in chat, but didn`t get a response ;/

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to fix the UI bug with input width
image
image

Remove these files
image

Comment on lines 17 to 19
case 'active':
return !todo.completed;
case 'completed':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use enum for 'all', 'active', 'completed'

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for pass test try to write empty array to local storage if no exists todos keys in local storage (user enter first time in app)

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants