Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #1103

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Develop #1103

wants to merge 7 commits into from

Conversation

Mariana-VV
Copy link

@Mariana-VV Mariana-VV commented Jan 17, 2025 •
edited
Loading

anastasiiavorobiova
anastasiiavorobiova suggested changes Jan 18, 2025
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider deploying your page and providing a link to the deployed page in the PR description

etojeDenys
etojeDenys suggested changes Jan 19, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image remove zeros
  1. fix styles for input
image

src/components/Header.tsx Outdated
Comment on lines 27 to 29
todos.filter(t => t.completed === true).length === todos.length
? true
: false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
todos.filter(t => t.completed === true).length === todos.length
? true
: false;
todos.filter(t => t.completed === true).length === todos.length;

@Mariana-VV Mariana-VV requested a review from etojeDenys January 19, 2025 12:21
VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Jan 19, 2025
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mariana-VV @VitaliyBondarenko1982 @etojeDenys @anastasiiavorobiova