Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #726

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Develop #726

wants to merge 5 commits into from

Conversation

Marinakyrychynska
Copy link

etojeDenys
etojeDenys suggested changes Oct 12, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. let's select the all tab by default
image
  1. not implemented
image
  1. you should delete the todo when the user tries to submit an empty edit input
image
  1. on double todo click you should show the input with the todo title as the value

sTorba24
sTorba24 approved these changes Oct 16, 2023
View reviewed changes
Copy link

@sTorba24 sTorba24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sTorba24 sTorba24 sTorba24 approved these changes

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marinakyrychynska @sTorba24 @etojeDenys