Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done #730

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

yurii-shkrobut-m
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍
Let's improve your code

src/App.tsx Outdated
<input type="text" className="edit" />
</li>
</ul>
{todos.length > 0 && (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{todos.length > 0 && (
{!!todos.length && (

src/App.tsx Outdated
Comment on lines 88 to 93
{todoCount === 1 ? (
`${todoCount} item left`
) : (
`${todoCount} items left`
)}
</span>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{todoCount === 1 ? (
`${todoCount} item left`
) : (
`${todoCount} items left`
)}
</span>
{`${todoCount === 1 ? 'item' : 'items'} left`}
</span>

<li
className={cn({
editing: isEdit,
completed: completed === true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
completed: completed === true,
completed: completed,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es-lint error

Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got this, keep pushing forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants