-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Done #730
base: master
Are you sure you want to change the base?
Done #730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 👍
Let's improve your code
src/App.tsx
Outdated
<input type="text" className="edit" /> | ||
</li> | ||
</ul> | ||
{todos.length > 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{todos.length > 0 && ( | |
{!!todos.length && ( |
src/App.tsx
Outdated
{todoCount === 1 ? ( | ||
`${todoCount} item left` | ||
) : ( | ||
`${todoCount} items left` | ||
)} | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{todoCount === 1 ? ( | |
`${todoCount} item left` | |
) : ( | |
`${todoCount} items left` | |
)} | |
</span> | |
{`${todoCount === 1 ? 'item' : 'items'} left`} | |
</span> |
src/components/TodoItem.tsx
Outdated
<li | ||
className={cn({ | ||
editing: isEdit, | ||
completed: completed === true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completed: completed === true, | |
completed: completed, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
es-lint error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got this, keep pushing forward!
DEMO LINK