add task solution #771
Open
add task solution #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Nov 14, 2023
src/Components/TodoApp/TodoApp.tsx
Outdated
| data-cy="toggleAll" | ||
| onChange={handlerCompleteAll} | ||
| /> | ||
| {todos.length !== 0 && ( |
There was a problem hiding this comment.
this condition looks redundant, 'cause you have the same above
src/Components/TodoApp/TodoApp.tsx
Outdated
Comment on lines
118
to
138
| <footer className="footer"> | ||
| <span className="todo-count" data-cy="todosCounter"> | ||
| {`${noCompleteTodos.length} items left`} | ||
| </span> | ||
|
|
||
| <TodosFilter | ||
| currentFilter={filter} | ||
| onFilterChange={handlerFilterChange} | ||
| /> | ||
|
|
||
| {isSomeComplete && ( | ||
| <button | ||
| type="button" | ||
| className="clear-completed" | ||
| onClick={handlerClearCompletes} | ||
| > | ||
| Clear completed | ||
| </button> | ||
| )} | ||
|
|
||
| </footer> |
There was a problem hiding this comment.
let's create the separate Footer component
|
|
||
| type Props = { | ||
| currentFilter: string, | ||
| onFilterChange?: (filter: string) => void |
There was a problem hiding this comment.
Suggested change
| onFilterChange?: (filter: string) => void | |
| onFilterChange: (filter: string) => void |
why it can be undefined
src/Components/TodoApp/TodoApp.tsx
Outdated
Comment on lines
82
to
107
| <form | ||
| onSubmit={handlerAddTodo} | ||
| onBlur={handlerAddTodo} | ||
| > | ||
| <input | ||
| type="text" | ||
| data-cy="createTodo" | ||
| className="new-todo" | ||
| placeholder="What needs to be done?" | ||
| value={title} | ||
| onChange={handlerChangeTitle} | ||
| /> | ||
| </form> | ||
| </header> | ||
|
|
||
| {todos.length !== 0 && ( | ||
| <section className="main"> | ||
|
|
||
| <input | ||
| checked={allCompleted} | ||
| type="checkbox" | ||
| id="toggle-all" | ||
| className="toggle-all" | ||
| data-cy="toggleAll" | ||
| onChange={handlerCompleteAll} | ||
| /> |
There was a problem hiding this comment.
you can also create the separate component for form with header
There was a problem hiding this comment.
it should improve the readability and performance in App.tsx
etojeDenys
suggested changes
Nov 27, 2023
src/App.tsx
Outdated
Comment on lines
157
to
159
| const handleChangeTodoTitle = (event: string) => { | ||
| setIsEdited(event); | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const handleChangeTodoTitle = (event: string) => { | |
| setIsEdited(event); | |
| }; | |
| const handleChangeTodoTitle = (title: string) => { | |
| setIsEdited(title); | |
| }; |
it's not the event
src/сomponents/TodoList/TodoList.tsx
Outdated
Comment on lines
36
to
63
| <li | ||
| className={cn({ | ||
| completed: todo.completed, | ||
| editing: todo.title === edit, | ||
| })} | ||
| key={todo.id} | ||
| onDoubleClick={() => { | ||
| onEdit(todo.title); | ||
| setCurrInputValue(todo.title); | ||
| }} | ||
| > | ||
| <div className="view"> | ||
| <input | ||
| type="checkbox" | ||
| className="toggle" | ||
| id={`${todo.id}`} | ||
| checked={todo.completed} | ||
| onChange={() => onChange(todo.id)} | ||
| /> | ||
| <label> | ||
| {todo.title} | ||
| </label> | ||
| <button | ||
| type="button" | ||
| aria-label="destroy" | ||
| className="destroy" | ||
| data-cy="deleteTodo" | ||
| onClick={() => onDelete(todo.id)} |
There was a problem hiding this comment.
my suggestion to you is that it will be better to create the TodoItem component and move a big part of the logic from the app. tsx to that component.
It should improve the readability by at least
mrogozhinskaya
force-pushed
the
develop
branch
from
9657b38 to
e7bc878
Compare
|
Done) |
etojeDenys
approved these changes
Nov 28, 2023
Comment on lines
+20
to
+21
| return ( | ||
| todos.length ? ( |
There was a problem hiding this comment.
Suggested change
| return ( | |
| todos.length ? ( | |
| if(todos.length) { | |
| return null | |
| } | |
| return ( |
it looks much better (you can also move that condition in App.tsx)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK