react_todo-app solution #773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Nov 15, 2023
src/components/TodoFilter.tsx
Outdated
| <li> | ||
| <a | ||
| href="#/" | ||
| className={filter === 'all' ? 'selected' : ''} |
There was a problem hiding this comment.
we usually use classnames for such cases
src/App.tsx
Outdated
Comment on lines
65
to
91
| <> | ||
| <section className="main"> | ||
| <input | ||
| type="checkbox" | ||
| id="toggle-all" | ||
| className="toggle-all" | ||
| data-cy="toggleAll" | ||
| onClick={toggleCompletionOfAllTodos} | ||
| /> | ||
| <label htmlFor="toggle-all">Mark all as complete</label> | ||
|
|
||
| <Todolist | ||
| todos={filteredTodos} | ||
| /> | ||
| </section> | ||
|
|
||
| <footer className="footer" data-cy="todosFilter"> | ||
| <span className="todo-count" data-cy="todosCounter"> | ||
| {todoCount === 1 | ||
| ? `${todoCount} item left` | ||
| : `${todoCount} items left`} | ||
| </span> | ||
|
|
||
| <TodoFilter | ||
| filter={filter} | ||
| setFilter={setFilter} | ||
| /> |
There was a problem hiding this comment.
you can create separate components for this, to simplify App.tsx
src/App.tsx
Outdated
Comment on lines
52
to
59
| <form onSubmit={handleFormSubmit}> | ||
| <input | ||
| type="text" | ||
| data-cy="createTodo" | ||
| className="new-todo" | ||
| placeholder="What needs to be done?" | ||
| value={query} | ||
| onChange={handleTitleChange} |
src/App.tsx
Outdated
Comment on lines
11
to
21
| const todosContext = useContext(TodosContext); | ||
|
|
||
| const { | ||
| todos, | ||
| addTodo, | ||
| deleteCompletedTodos, | ||
| toggleCompletionOfAllTodos, | ||
| todoCount, | ||
| completedTodos, | ||
| filterTodos, | ||
| } = todosContext; |
There was a problem hiding this comment.
Suggested change
| const todosContext = useContext(TodosContext); | |
| const { | |
| todos, | |
| addTodo, | |
| deleteCompletedTodos, | |
| toggleCompletionOfAllTodos, | |
| todoCount, | |
| completedTodos, | |
| filterTodos, | |
| } = todosContext; | |
| const { | |
| todos, | |
| addTodo, | |
| deleteCompletedTodos, | |
| toggleCompletionOfAllTodos, | |
| todoCount, | |
| completedTodos, | |
| filterTodos, | |
| } = useContext(TodosContext); |
IvanFesenko
approved these changes
Nov 15, 2023
Comment on lines
+64
to
+66
|
|
||
| todo.title = newTodo; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK