dev #783
Open
dev #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Nov 18, 2023
src/App.tsx
Outdated
| const handleSubmit = (event: React.FormEvent) => { | ||
| event.preventDefault(); | ||
| if (query.trim()) { | ||
| setTodos([...todos, { id: Date.now(), title: query, completed: false }]); |
There was a problem hiding this comment.
Suggested change
| setTodos([...todos, { id: Date.now(), title: query, completed: false }]); | |
| const todo = { | |
| id: Date.now(), | |
| title: query, | |
| completed: false, | |
| }; | |
| setTodos([...todos, todo]); |
| <a href="#/completed">Completed</a> | ||
| </li> | ||
| </ul> | ||
| <TodosContext.Provider |
There was a problem hiding this comment.
Move provider to the context file, it will be a good practice
src/components/TodoList.tsx
Outdated
| <ul className="todo-list" data-cy="todosList"> | ||
| {todos.filter((todo) => { | ||
| switch (todosFilter) { | ||
| case 'Active': |
src/components/TodoList.tsx
Outdated
Comment on lines
13
to
22
| {todos.filter((todo) => { | ||
| switch (todosFilter) { | ||
| case 'Active': | ||
| return !todo.completed; | ||
| case 'Completed': | ||
| return todo.completed; | ||
| default: | ||
| return true; | ||
| } | ||
| }).map((todo) => ( |
There was a problem hiding this comment.
Move this logic from the jsx to the helper function and use it here
SanyaBratashchuk
suggested changes
Nov 19, 2023
src/App.tsx
Outdated
| completed: false, | ||
| }; | ||
|
|
||
| setTodos([...todos, todo]); |
There was a problem hiding this comment.
Suggested change
| setTodos([...todos, todo]); | |
| setTodos(prevTodos => [...prevTodos, todo]); |
It is safer to pass updater callback when new state values depends on previous one
src/components/TodoContent.tsx
Outdated
Comment on lines
18
to
20
| setTodos(todos.map(todo => { | ||
| return { ...todo, completed: !isCompleted }; | ||
| })); |
src/components/TodoFooter.tsx
Outdated
Comment on lines
18
to
20
| const isCompleted = todos.some(todo => todo.completed); | ||
|
|
||
| const todosLeft = todos.filter(todo => todo.completed === false).length; |
There was a problem hiding this comment.
Suggested change
| const isCompleted = todos.some(todo => todo.completed); | |
| const todosLeft = todos.filter(todo => todo.completed === false).length; | |
| const isCompleted = todos.some(todo => todo.completed); | |
| const todosLeft = todos.filter(todo => !todo.completed).length; |
volodymyr-soltys97
suggested changes
Nov 20, 2023
src/components/TodoItem.tsx
Outdated
Comment on lines
66
to
70
| case 'Escape': | ||
| resetChange(); | ||
|
|
||
| break; | ||
| case 'Enter': |
There was a problem hiding this comment.
Suggested change
| case 'Escape': | |
| resetChange(); | |
| break; | |
| case 'Enter': | |
| case 'Escape': | |
| resetChange(); | |
| break; | |
| case 'Enter': |
src/components/TodoItem.tsx
Outdated
Comment on lines
79
to
82
| saveChange(); | ||
|
|
||
| break; | ||
| default: |
There was a problem hiding this comment.
Suggested change
| saveChange(); | |
| break; | |
| default: | |
| saveChange(); | |
| break; | |
| default: |
src/components/TodoList.tsx
Outdated
|
|
||
| return ( | ||
| <ul className="todo-list" data-cy="todosList"> | ||
| {filterTodos(todos, todosFilter).map((todo) => ( |
There was a problem hiding this comment.
Consider will be better if you create a variable for this checking and use it here filterTodos(todos, todosFilter)
Suggested change
| {filterTodos(todos, todosFilter).map((todo) => ( | |
| {filterTodos(todos, todosFilter).map((todo) => ( |
src/hooks/useLocalStorage.ts
Outdated
Comment on lines
10
to
12
| if (data === null) { | ||
| return startValue; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (data === null) { | |
| return startValue; | |
| } | |
| if (!data) { | |
| return startValue; | |
| } |
VitaliyBodnar
suggested changes
Nov 20, 2023
src/components/TodoContent.tsx
Outdated
Comment on lines
19
to
26
| setTodos((prevTodos: Todo[]) => { | ||
| const updatedTodos = prevTodos.map(todo => ({ | ||
| ...todo, | ||
| completed: !isCompleted, | ||
| })); | ||
|
|
||
| return updatedTodos; | ||
| }); |
There was a problem hiding this comment.
Suggested change
| setTodos((prevTodos: Todo[]) => { | |
| const updatedTodos = prevTodos.map(todo => ({ | |
| ...todo, | |
| completed: !isCompleted, | |
| })); | |
| return updatedTodos; | |
| }); | |
| setTodos((prevTodos: Todo[]) => prevTodos.map(todo => ({ | |
| ...todo, | |
| completed: !isCompleted, | |
| })); | |
| ); |
src/components/TodoItem.tsx
Outdated
Comment on lines
66
to
70
| case 'Escape': | ||
| resetChange(); | ||
| break; | ||
|
|
||
| case 'Enter': |
There was a problem hiding this comment.
Please move Enter and Escape to the enum as it will make a code cleaner
loralevitska
suggested changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK