commited unworking code #804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerastarynets
suggested changes
Dec 12, 2023
src/components/Todos.tsx
Outdated
Comment on lines
6
to
7
| removeItem, | ||
| markAsCompleted |
There was a problem hiding this comment.
u don't use these 2 functions in this component
lerastarynets
suggested changes
Dec 20, 2023
etojeDenys
suggested changes
Dec 21, 2023
There was a problem hiding this comment.
try to fix this difference in height when user tries to edit the todo
https://github.com/mate-academy/react_todo-app/assets/70220667/e87259cc-b553-4ed8-8eb8-a2df19c16ff5
src/components/Todos.tsx
Outdated
Comment on lines
16
to
47
| {filter === 'all' && ( | ||
| todos | ||
| .map((todoItem) => ( | ||
| <Todo | ||
| key={todoItem.id} | ||
| todoItem={todoItem} | ||
| onItemDelete={handleDelete} | ||
| /> | ||
| )) | ||
| )} | ||
| {filter === 'active' && ( | ||
| todos | ||
| .filter((todoItem) => todoItem.completed === false) | ||
| .map((todoItem) => ( | ||
| <Todo | ||
| key={todoItem.id} | ||
| todoItem={todoItem} | ||
| onItemDelete={handleDelete} | ||
| /> | ||
| )) | ||
| )} | ||
| {filter === 'completed' && ( | ||
| todos | ||
| .filter((todoItem) => todoItem.completed === true) | ||
| .map((todoItem) => ( | ||
| <Todo | ||
| key={todoItem.id} | ||
| todoItem={todoItem} | ||
| onItemDelete={handleDelete} | ||
| /> | ||
| )) | ||
| )} |
There was a problem hiding this comment.
looks too complex, just filter the array before the jsx, save in some variable and map in return
src/components/Footer.tsx
Outdated
|
|
||
| export const Footer = () => { | ||
| const { state: { todos }, dispatch } = React.useContext(TodosContext); | ||
| const [state, setState] = useState(todos); |
There was a problem hiding this comment.
it can be the simple variable instead of the state
src/App.tsx
Outdated
| <input type="text" className="edit" /> | ||
| </li> | ||
| const { state: { todos } } = React.useContext(TodosContext); | ||
| const [tasksLength, setTasksLength] = useState(todos.length); |
sTorba24
suggested changes
Dec 23, 2023
src/components/Main.tsx
Outdated
Comment on lines
10
to
14
| if (labelClick % 2 === 0) { | ||
| dispatch({ type: 'MARK_ALL_AS_UNCOMPLETED' }); | ||
| } else { | ||
| dispatch({ type: 'MARK_ALL_AS_COMPLETED' }); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (labelClick % 2 === 0) { | |
| dispatch({ type: 'MARK_ALL_AS_UNCOMPLETED' }); | |
| } else { | |
| dispatch({ type: 'MARK_ALL_AS_COMPLETED' }); | |
| } | |
| dispatch({ type: !(labelClick % 2) | |
| ? 'MARK_ALL_AS_UNCOMPLETED' | |
| : 'MARK_ALL_AS_COMPLETED' | |
| }); |
src/components/Main.tsx
Outdated
Comment on lines
17
to
37
| if (!todos.length) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <section className="main"> | ||
| <input | ||
| onClick={handleToggleAll} | ||
| type="checkbox" | ||
| id="toggle-all" | ||
| className="toggle-all" | ||
| data-cy="toggleAll" | ||
| /> | ||
| <label | ||
| htmlFor="toggle-all" | ||
| > | ||
| Mark all as completed | ||
| </label> | ||
| <Todos /> | ||
| </section> | ||
| ); |
There was a problem hiding this comment.
Suggested change
| if (!todos.length) { | |
| return null; | |
| } | |
| return ( | |
| <section className="main"> | |
| <input | |
| onClick={handleToggleAll} | |
| type="checkbox" | |
| id="toggle-all" | |
| className="toggle-all" | |
| data-cy="toggleAll" | |
| /> | |
| <label | |
| htmlFor="toggle-all" | |
| > | |
| Mark all as completed | |
| </label> | |
| <Todos /> | |
| </section> | |
| ); | |
| return ( | |
| { todos.length > 0 && ( | |
| <section className="main"> | |
| <input | |
| onClick={handleToggleAll} | |
| type="checkbox" | |
| id="toggle-all" | |
| className="toggle-all" | |
| data-cy="toggleAll" | |
| /> | |
| <label | |
| htmlFor="toggle-all" | |
| > | |
| Mark all as completed | |
| </label> | |
| <Todos /> | |
| </section> | |
| ) | |
| } | |
| ); |
src/components/Todos.tsx
Outdated
Comment on lines
19
to
53
| return ( | ||
| <ul className="todo-list" data-cy="todoList"> | ||
| {filter === 'all' && ( | ||
| todos | ||
| .map((todoItem) => ( | ||
| <Todo | ||
| key={todoItem.id} | ||
| todoItem={todoItem} | ||
| onItemDelete={handleDelete} | ||
| /> | ||
| )) | ||
| )} | ||
| {filter === 'active' && ( | ||
| activeFilter | ||
| .map((todoItem) => ( | ||
| <Todo | ||
| key={todoItem.id} | ||
| todoItem={todoItem} | ||
| onItemDelete={handleDelete} | ||
| /> | ||
| )) | ||
| )} | ||
| {filter === 'completed' && ( | ||
| complietedFilter | ||
| .map((todoItem) => ( | ||
| <Todo | ||
| key={todoItem.id} | ||
| todoItem={todoItem} | ||
| onItemDelete={handleDelete} | ||
| /> | ||
| )) | ||
| )} | ||
|
|
||
| </ul> | ||
| ); |
There was a problem hiding this comment.
prepare filtered todos before render just, and then use only variable filteredTodos, now logic is too complicated
lerastarynets
suggested changes
Dec 26, 2023
src/components/Main.tsx
Outdated
Comment on lines
17
to
37
| if (!todos.length) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <section className="main"> | ||
| <input | ||
| onClick={handleToggleAll} | ||
| type="checkbox" | ||
| id="toggle-all" | ||
| className="toggle-all" | ||
| data-cy="toggleAll" | ||
| /> | ||
| <label | ||
| htmlFor="toggle-all" | ||
| > | ||
| Mark all as completed | ||
| </label> | ||
| <Todos /> | ||
| </section> | ||
| ); |
sTorba24
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://OPTIMISTIXX.github.io/react_todo-app/