create todo app #807
Open
create todo app #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBodnar
suggested changes
Dec 14, 2023
src/App.tsx
Outdated
| Clear completed | ||
| </button> | ||
| </footer> | ||
| <TodosFilter /> |
There was a problem hiding this comment.
Suggested change
| <TodosFilter /> | |
| <TodosFilter /> |
| }, [isEdit]); | ||
|
|
||
| const handleKeyDown = (event: React.KeyboardEvent<HTMLInputElement>) => { | ||
| if (event.key === 'Enter' && editingText) { |
There was a problem hiding this comment.
enter is a magic word
Consider will be better if you create a enum for magic words and use it everywhere
| const completedFilter = filterTodos.filter((todo: Todos) => todo.completed); | ||
|
|
||
| switch (status) { | ||
| case Status.all: |
There was a problem hiding this comment.
enum's items should be in camelCase or UPPER_CASE
Suggested change
| case Status.all: | |
| case Status.All: |
src/Types/Status.tsx
Outdated
| completed = '#/completed', | ||
| } | ||
|
|
||
| export default Status; |
There was a problem hiding this comment.
redundant
Suggested change
| export default Status; |
src/Types/Todos.tsx
Outdated
Comment on lines
1
to
7
| type Todos = { | ||
| id: number | ||
| title: string | ||
| completed: boolean | ||
| }; | ||
|
|
||
| export default Todos; |
There was a problem hiding this comment.
Suggested change
| type Todos = { | |
| id: number | |
| title: string | |
| completed: boolean | |
| }; | |
| export default Todos; | |
| export type Todos = { | |
| id: number | |
| title: string | |
| completed: boolean | |
| }; |
etojeDenys
suggested changes
Dec 15, 2023
| <ul className="todo-list" data-cy="todoList"> | ||
| {filterTodos.map((todo) => ( | ||
| <TodoItem | ||
| key={`${todo.id}`} |
There was a problem hiding this comment.
Suggested change
| key={`${todo.id}`} | |
| key={todo.id} |
VitaliyBodnar
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK