-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #35
base: main
Are you sure you want to change the base?
Solution #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
src/components/AddCommentForm.vue
Outdated
<label class="label" for="comment-author-name-name">Author Name</label> | ||
<div class="control has-icons-left has-icons-right"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding space between elements on one level of depths
src/components/PostsTable.vue
Outdated
<td>{{ post.id }}</td> | ||
<td>{{ post.title }}</td> | ||
<td class="has-text-right is-vcentered"> | ||
<button | ||
type="button" | ||
class="button is-link" | ||
:class="{ 'is-light': currentPost.id !== post.id }" | ||
@click="$emit('openPost', post)" | ||
> | ||
{{ currentPost.id === post.id ? 'Close' : 'Open' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using destruction assignment for post
object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
vue_dynamic-list of-posts
DEMO LINK