Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #35

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Solution #35

wants to merge 4 commits into from

Conversation

YuriiHlushenko
Copy link

vue_dynamic-list of-posts

DEMO LINK

Copy link

@GUSILLUS GUSILLUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Comment on lines 34 to 35
<label class="label" for="comment-author-name-name">Author Name</label>
<div class="control has-icons-left has-icons-right">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding space between elements on one level of depths

Comment on lines 56 to 65
<td>{{ post.id }}</td>
<td>{{ post.title }}</td>
<td class="has-text-right is-vcentered">
<button
type="button"
class="button is-link"
:class="{ 'is-light': currentPost.id !== post.id }"
@click="$emit('openPost', post)"
>
{{ currentPost.id === post.id ? 'Close' : 'Open' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using destruction assignment for post object

@YuriiHlushenko YuriiHlushenko requested a review from GUSILLUS August 4, 2024 10:43
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants