-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(Timepicker) implementation with confirmation buttons util #575
base: v2-dev
Are you sure you want to change the base?
enhancement(Timepicker) implementation with confirmation buttons util #575
Conversation
…; configured confirmation buttons to render when auto submit is false materializecss#558
…rmation container only if auto submit is false; removed timeout since its redundant; fixed incorrect callback option check in cancel callback materializecss#570
Implemented additional check to render confirmation container only if auto submit is false (as in #572) This is ready for review |
Thanks for the awesome work! I will take a look next year and review it. Best wishes to all contributors and take care going into the new year. See you all soon ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like the approach with creating the button elements dynamically.
We should consider a create function for other elements as well.
The merge-base changed after approval.
Proposed changes
This pull request is a follow up of #572 and #574 and handles the implementation of the Utils.createButton with callback method and the Utils.createConfirmContainer with callback methods
With the callback function, we can open and close modal (or custom) implementation in combination with timepicker with the onDone and onCancel callbacks
Example:
html
script
Checklist: