Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(DockedDisplayPlugin) implemented docked display plugin #582

Merged
merged 5 commits into from
Feb 18, 2025

Conversation

gselderslaghs
Copy link
Member

Proposed changes

This pull requests introduces a new feature, the "Docked Display Plugin" the first step towards implementing #140
The idea is to bring up a plugin that can be used in multiple components, eg. timepicker, datepicker, etc.
I made the positioning methods shared from the tooltip component, in a later refactor we could introduce implementing the shared Utility method in Tooltips as wel

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably aim for popover and anchor positioning in future https://caniuse.com/css-anchor-positioning

@gselderslaghs
Copy link
Member Author

We should probably aim for popover and anchor positioning in future https://caniuse.com/css-anchor-positioning

This is what we already needed long time ago, nice this feature is finally being implemented, hopefully it will have wide browser support soon 👀

@wuda-io wuda-io merged commit a9813ab into materializecss:v2-dev Feb 18, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants