Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(Datepicker) implementation with confirmation buttons util #592

Open
wants to merge 22 commits into
base: v2-dev
Choose a base branch
from

Conversation

gselderslaghs
Copy link
Member

Proposed changes

This pull request is a follow up of #571 and #574 and handles the implementation of the Utils.createButton with callback method and the Utils.createConfirmContainer with callback methods

Example with buttons

const input = document.querySelector('.datepicker');
M.Datepicker.init(input, {
    autoSubmit: false,
    showClearBtn: true
});

Example without buttons:

M.Datepicker.init(input, {
    autoSubmit: true,
    showClearBtn: false
});

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ell to initial, implemented additional is-daterange-start + is-daterange-end classes and refactored styling to use pseudo selectors on newly created classes materializecss#360
… display font size adjustment when rendering multiple dates
…oard event; implemented dispatch event for enter keydown; refactored deprecated expectations by withContext method
…ubmit is true by default; implement additional spec test for integration with action util buttons
@gselderslaghs
Copy link
Member Author

Changelog

  • Refactored existing spec test to not depend on previously implemented confirm button interaction
  • Implemented additional spec test on action util buttons integration by option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant